[webkit-reviews] review granted: [Bug 80029] [Qt][WK2] Make the interaction with the Flickable work on the N9 : [Attachment 129706] proposed patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Andras Becsi
<abecsi at webkit.org>'s request for review:
Bug 80029: [Qt][WK2] Make the interaction with the Flickable work on the N9
https://bugs.webkit.org/show_bug.cgi?id=80029

Attachment 129706: proposed patch
https://bugs.webkit.org/attachment.cgi?id=129706&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129706&action=review


> Source/WebKit2/UIProcess/qt/QtFlickProvider.cpp:156
> +    QCoreApplication::sendEvent(m_flickable->canvas(), &mouseEvent);

This is a bit unfortunately, it sounds like we need a function in QQuickCanvas
to send an event to a specific item, in order to ensure delivery. Couldn't
theoretically the event end up in a different item if it happens to be "on
top"? (of course we shouldn't have received the touch event in the first place
then...)

Anyway, this is an improvement and clearly makes the code more robust (less
relying on magic event conversion elsewhere).