[webkit-reviews] review denied: [Bug 64596] Web Inspector: arrays in object properties sections do not scale. : [Attachment 129694] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 64596: Web Inspector: arrays in object properties sections do not scale.
https://bugs.webkit.org/show_bug.cgi?id=64596

Attachment 129694: Patch
https://bugs.webkit.org/attachment.cgi?id=129694&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129694&action=review


Looks like this needs a test.

> Source/WebCore/inspector/front-end/ConsoleMessage.js:291
> +	   if (array.arrayLength() > 100)

Maybe use const?

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:382
> +    TreeElement.call(this, "[" + this._properties[fromIndex].name + " \u2026
" + this._properties[toIndex - 1].name + "]", null, true);

var title = fromIndex === toIndex - 1 ? "[" + this._properties[fromIndex].name
+ " \u2026 " + this._properties[toIndex - 1].name + "]" :
this._properties[fromIndex].name;
TreeElement.call(this, title, null, true);

> Source/WebCore/inspector/front-end/ObjectPropertiesSection.js:404
> +	   treeElement._readOnly = true; 

So we can not edit any array shown as dir(array) even if it shorter than 20
elements?

> Source/WebCore/inspector/front-end/RemoteObject.js:313
> +	   return parseInt(this._description.match(/[0-9]+/), 10);

Maybe
var matches = this._description.match(/\[([0-9]+)\]/))
return parseInt(matches[1], 10);
would be better?