[webkit-reviews] review canceled: [Bug 79932] Make use of CG rounded-rect primitives : [Attachment 129683] Follow-up patch

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has canceled Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 79932: Make use of CG rounded-rect primitives
https://bugs.webkit.org/show_bug.cgi?id=79932

Attachment 129683: Follow-up patch
https://bugs.webkit.org/attachment.cgi?id=129683&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
(In reply to comment #9)
> I've switched to the old code path for SVG again, as dashed strokes seem to
fail with the new native approach. Maybe it'll never work as SVG expects it.

I've discussed this with Zoltan on IRC -- I'm holding back this patch, we
should discuss with Tim/Simon first if wkCGPathAddRoundedRect can be fixed, if
not, we can revisit my patch, but only pass the 'PreferBeziers..' argument if
the SVG stroke-dasharray is set, otherwise use the default PreferNative method.


I'm going to roll this out instead for now, to have passing tests again.