[webkit-reviews] review canceled: [Bug 62698] Support for Battery Status API : [Attachment 99940] Add events for the revised spec.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 1 05:13:15 PST 2012


Kihong Kwon <kihong.kwon at samsung.com> has canceled Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 62698: Support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=62698

Attachment 99940: Add events for the revised spec.
https://bugs.webkit.org/attachment.cgi?id=99940&action=review

------- Additional Comments from Kihong Kwon <kihong.kwon at samsung.com>
I have an issue about this patch.
Battery Status API has to be added under the Navigator class, but there is no
event handling logic in the navigator.
So I implemented event listener handling logic to the BatteryManager, because I
didn't have other choice,
but I think this is not good to add event listener to the Battery Status API.
I think navigator needs event listener handling logic like a DOMWindow.
Leave some comments about this please.
Thank you.


More information about the webkit-reviews mailing list