[webkit-reviews] review granted: [Bug 79448] REGRESSION: Outlook 2007 doesn't display fonts correctly on emails composed by WebKit : [Attachment 129648] Patch

Thu Mar 1 00:13:38 PST 2012

Ryosuke Niwa <rniwa at webkit.org> has granted Kenichi Ishibashi
<bashi at chromium.org>'s request for review:
Bug 79448: REGRESSION: Outlook 2007 doesn't display fonts correctly on emails
composed by WebKit
https://bugs.webkit.org/show_bug.cgi?id=79448

Attachment 129648: Patch
https://bugs.webkit.org/attachment.cgi?id=129648&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=129648&action=review

> Source/WebCore/ChangeLog:8
> +	   Reviewed by NOBODY (OOPS!).

This line should appear before the description.

> LayoutTests/ChangeLog:9
> +	   Reviewed by NOBODY (OOPS!).

Ditto.

> LayoutTests/editing/style/font-face-unquote-expected.txt:1
> +Test to make sure WebKit doesn't quote font face.

in face content attribute? I mean we do quote them in font-family property
value, right?

> LayoutTests/editing/style/font-face-unquote.html:6
> +<head>
> +<meta charset="utf-8">
> +<script src="../../fast/js/resources/js-test-pre.js"></script>
> +</head>

You can just put the script element in body and there's no need for the meta.