[webkit-reviews] review granted: [Bug 89461] Web Inspector: Design WebSockets panel : [Attachment 150264] Opcodes enum, String.sprintf

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Nikita Vasilyev
<me at elv1s.ru>'s request for review:
Bug 89461: Web Inspector: Design WebSockets panel
https://bugs.webkit.org/show_bug.cgi?id=89461

Attachment 150264: Opcodes enum, String.sprintf
https://bugs.webkit.org/attachment.cgi?id=150264&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150264&action=review


Looks good! Please fix the indent and I will cq+ it!

> Source/WebCore/inspector/front-end/ResourceWebSocketFrameView.js:60
> +		   case
WebInspector.ResourceWebSocketFrameView.OpCodes.ContinuationFrame:

nit: WebKit does not indent case:

> Source/WebCore/inspector/front-end/ResourceWebSocketFrameView.js:76
> +	       row.data = String.sprintf("%s (Opcode %d%s)", opcodeMeaning,
payload.opcode, (payload.mask ? ", mask" : ""));

Nit: You might want to do WebInspector.UIString("%s (Opcode %d%s)", ...) and
put %s (Opcode %d%s) into the localized strings.