[webkit-reviews] review granted: [Bug 84532] [Qt][WK2] Private non-QtQuick API : [Attachment 150279] patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam.rosenthal at nokia.com> has granted Luiz Agostini
<luiz at webkit.org>'s request for review:
Bug 84532: [Qt][WK2] Private non-QtQuick API
https://bugs.webkit.org/show_bug.cgi?id=84532

Attachment 150279: patch
https://bugs.webkit.org/attachment.cgi?id=150279&action=review

------- Additional Comments from Noam Rosenthal <noam.rosenthal at nokia.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150279&action=review


OK, this seems to cover comments from everyone, also we agreed with several
people on the naming and directory scheme with torarne and others.
It's time to move this forward - if there are any additional concerns/changes
let's make them on top.

> Source/WebKit2/ChangeLog:8
> +

Please describe the test, and the fact that right now most of the functionality
is not implemented other than the minimum needed to get web content on the
screen.

> Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p.h:88
> +    void paint(const QMatrix4x4& transform, float opacity, unsigned
paintFlags);

Add a comment saying that this assumes a current GL context.

> Source/WebKit2/UIProcess/API/qt/raw/qrawwebview_p.h:95
> +    void keyEvent(QKeyEvent*);
> +    void mouseEvent(QMouseEvent*, int clickCount = 0);
> +    void wheelEvent(QWheelEvent*);
> +    void touchEvent(QTouchEvent*);

sendKeyEvent etc.