[webkit-reviews] review granted: [Bug 90300] [chromium] Use CCThread::Task in compositor's RateLimiter instead of Timer : [Attachment 150238] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 29 14:43:30 PDT 2012
Adrienne Walker <enne at google.com> has granted James Robinson
<jamesr at chromium.org>'s request for review:
Bug 90300: [chromium] Use CCThread::Task in compositor's RateLimiter instead of
Timer
https://bugs.webkit.org/show_bug.cgi?id=90300
Attachment 150238: Patch
https://bugs.webkit.org/attachment.cgi?id=150238&action=review
------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150238&action=review
R=me. Looks reasonable to me.
> Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHost.cpp:132
> + RateLimiterMap::iterator it = m_rateLimiters.begin();
> + if (it != m_rateLimiters.end())
> + it->second->stop();
It's kind of dodgy that we didn't have this before, since something that
outlived the host could have taken a ref on the RateLimiter.
More information about the webkit-reviews
mailing list