[webkit-reviews] review denied: [Bug 90228] Do not do any logging initialization when logging is disabled : [Attachment 150059] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 90228: Do not do any logging initialization when logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=90228

Attachment 150059: Patch
https://bugs.webkit.org/attachment.cgi?id=150059&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150059&action=review


> Source/WebCore/ChangeLog:8
> +	   Initializating of the logging channels was taking time on startup.
When loggin is disabled

"loggin"

> Source/WebCore/ChangeLog:9
> +	   (and the LOG macro do nothing), we should aslo disable logging
channels and initialization.

do nothing -> does nothing. aslo.

> Source/WebCore/ChangeLog:12
> +	   The biggest part of the patch is the change from !LOG_DISABLED to
using ENABLE(LOGGING).
> +	   This is done for consistency with the other ENABLE features used in
WebKit.

But I don't think logging is like other ENABLE features. ENABLE is used for 
web- or user- facing features, and doesn't normally change between release and
debug builds. LOGGING is more like ASSERTS, in that it's disabled in release.