[webkit-reviews] review denied: [Bug 90261] Move platform/qt/fast/js/navigator-language.html to fast/js. : [Attachment 150154] Patch

Fri Jun 29 12:28:59 PDT 2012

Ryosuke Niwa <rniwa at webkit.org> has denied Kihong Kwon
<kihong.kwon at samsung.com>'s request for review:
Bug 90261: Move platform/qt/fast/js/navigator-language.html to fast/js.
https://bugs.webkit.org/show_bug.cgi?id=90261

Attachment 150154: Patch
https://bugs.webkit.org/attachment.cgi?id=150154&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150154&action=review

> LayoutTests/fast/js/navigator-language.html:10
> +    <head>
> +	   <script src="../../fast/js/resources/js-test-pre.js"></script>
> +    </head>
> +    <body>
> +	   <script>
> +	       description(
> +		   "<pre>Check return value of navigator.language."
> +	       );

Why are you indenting elements and scripts like this? We don't normally do
this.
Also, please use svn mv.

> LayoutTests/fast/js/navigator-language.html:18
> +				shouldBe("language", "'en'");

We use 4-space indentation, not tabs.