[webkit-reviews] review granted: [Bug 90092] [chromium] CanvasLayerTextureUpdater needs to convert opaque rects back to content space. : [Attachment 150226] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted vollick at chromium.org's request
for review:
Bug 90092: [chromium] CanvasLayerTextureUpdater needs to convert opaque rects
back to content space.
https://bugs.webkit.org/show_bug.cgi?id=90092

Attachment 150226: Patch
https://bugs.webkit.org/attachment.cgi?id=150226&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150226&action=review


R=me.  I find this far more easy to understand than the previous patch.  Thanks
also for going ahead and making the FloatRect change.

Also, if you're going to modify function signatures, can you add override while
you're at it?

> Source/WebCore/platform/graphics/chromium/ContentLayerChromium.h:61
> +    virtual void paint(SkCanvas*, const IntRect& contentRect, FloatRect&
opaque);

OVERRIDE

> Source/WebKit/chromium/src/WebContentLayerImpl.h:44
> +    virtual void paintContents(SkCanvas*, const WebCore::IntRect& clip,
WebCore::FloatRect& opaque);

OVERRIDE

> Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp:3670
> +    virtual void paintContents(SkCanvas*, const IntRect& clip, FloatRect&
opaque) { }

OVERRIDE

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:1145
> +    virtual void paintContents(SkCanvas*, const IntRect&, FloatRect&)

OVERRIDE

> Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp:1239
> +    void paintContents(SkCanvas*, const IntRect&, FloatRect&) { }

OVERRIDE

> Source/WebKit/chromium/tests/LayerChromiumTest.cpp:73
> +    virtual void paint(SkCanvas*, const IntRect&, FloatRect&) { }

OVERRIDE

> Source/WebKit/chromium/tests/TiledLayerChromiumTest.cpp:1508
> +    virtual void paint(SkCanvas*, const IntRect& contentRect, FloatRect&)

OVERRIDE