[webkit-reviews] review denied: [Bug 89670] Resolve CSS Exclusions shapeInside, shapeOutside properties to Length based WrapShape classes : [Attachment 150042] Initial patch with length-based WrapShapes

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Bear Travis
<betravis at adobe.com>'s request for review:
Bug 89670: Resolve CSS Exclusions shapeInside, shapeOutside properties to
Length based WrapShape classes
https://bugs.webkit.org/show_bug.cgi?id=89670

Attachment 150042: Initial patch with length-based WrapShapes
https://bugs.webkit.org/attachment.cgi?id=150042&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150042&action=review


> Source/WebCore/ChangeLog:12
> +	   Covered by existing tests in LayoutTests/fast/exclusions

It looks like you're adding a lot of new functionality here. I don't see how it
can be covered by existing tests. For example, you need tests with various
length units, including viewport-relative lengths.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:759
> +    case WrapShape::WRAP_SHAPE_RECTANGLE:
> +	   {

Brace should be on the previous line. Same with the case statements below.

> Source/WebCore/css/CSSWrapShapes.h:154
>      PassRefPtr<CSSPrimitiveValue> getXAt(unsigned i) { return m_values.at(i
* 2); }
>      PassRefPtr<CSSPrimitiveValue> getYAt(unsigned i) { return m_values.at(i
* 2 + 1); }
> +    const Vector<RefPtr<CSSPrimitiveValue> >& values() { return m_values; }
>  

These should all be |const|.

> Source/WebCore/css/StyleBuilder.cpp:1742
> +		   RefPtr<WrapShape> wrapShape = 0;

No need to initialize to 0.

> Source/WebCore/css/StyleBuilder.cpp:1759
> +			   wrapShape = rect;

You have an extra ref/deref here.You can say rect.release() to transfer
ownership.

> Source/WebCore/rendering/style/WrapShapes.h:77
> +    : m_radiusX(Undefined)
> +    , m_radiusY(Undefined)

These should be indented.

> Source/WebCore/rendering/style/WrapShapes.h:93
> +    Length left() const { return m_left; }
> +    Length top() const { return m_top; }

Seems odd to denote a circle by its top/left position, rather than the center.