[webkit-reviews] review requested: [Bug 86024] Enh: Hash Const JSString in Backing Stores to Save Memory : [Attachment 150197] Patch with fix for string hash ASSERT failures

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 29 09:40:38 PDT 2012


Michael Saboff <msaboff at apple.com> has asked  for review:
Bug 86024: Enh: Hash Const JSString in Backing Stores to Save Memory
https://bugs.webkit.org/show_bug.cgi?id=86024

Attachment 150197: Patch with fix for string hash ASSERT failures
https://bugs.webkit.org/attachment.cgi?id=150197&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
Updated the code for the case where two marking threads are in the process of
hash const'ing the same string.  Added a tryHashConstLock() to JSString.  When
a thread fails to get the lock, it gives up hash con sting the string.	The
winning thread will be able to hash const.  This eliminated several ASSERT
failure modes when two threads try to hash a string at nearly the same time.


More information about the webkit-reviews mailing list