[webkit-reviews] review granted: [Bug 89868] Web Inspector: [Extensions API] Resource manipulations should be based on UISourceCode thus extending Sources Panel. : [Attachment 149717] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 89868: Web Inspector: [Extensions API] Resource manipulations should be
based on UISourceCode thus extending Sources Panel.
https://bugs.webkit.org/show_bug.cgi?id=89868

Attachment 149717: Patch
https://bugs.webkit.org/attachment.cgi?id=149717&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149717&action=review


> Source/WebCore/inspector/front-end/ExtensionServer.js:486
> +	   var contentProvider =
WebInspector.panels.scripts.uiSourceCodeForURL(url) ||
WebInspector.resourceForURL(url);

This is not nice. Could we move composite provider into the WebInspector and
pass it into this class?

> Source/WebCore/inspector/front-end/ExtensionServer.js:509
> +	       else

We don't use else after return branches