[webkit-reviews] review denied: [Bug 90277] Web Inspector: added DecodeImage and ResizeImage events to TimelineAgent : [Attachment 150173] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 29 07:37:01 PDT 2012
Pavel Feldman <pfeldman at chromium.org> has denied Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 90277: Web Inspector: added DecodeImage and ResizeImage events to
TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90277
Attachment 150173: Patch
https://bugs.webkit.org/attachment.cgi?id=150173&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150173&action=review
As per my earlier comments (good that some of them are already addressed)
> Source/WebCore/inspector/InspectorInstrumentation.cpp:477
> + InspectorTimelineAgent::willDecodeImage(rect);
I'd use s_timelineAgent here and move setTimelineAgent into the
instrumentation.
More information about the webkit-reviews
mailing list