[webkit-reviews] review granted: [Bug 90149] Web Inspector: add v8 bindings memory info to the native memory graph : [Attachment 149914] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 90149: Web Inspector: add v8 bindings memory info to the native memory
graph
https://bugs.webkit.org/show_bug.cgi?id=90149

Attachment 149914: Patch
https://bugs.webkit.org/attachment.cgi?id=149914&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149914&action=review


> Source/WebCore/bindings/js/ScriptProfiler.h:81
> +    static void collectBindingMemoryInfo(MemoryInstrumentation*) { }

Please file a bug requesting that it is implemented for JSC and put FIXME here.


> Source/WebCore/bindings/v8/V8Binding.cpp:95
> +    instrumentation->reportPointer(this, MemoryInstrumentation::Binding);

I wonder if we could have a macro for these...