[webkit-reviews] review denied: [Bug 90264] Web Inspector: added low-level instrumentation support for TimelineAgent : [Attachment 150169] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Sergey Rogulenko
<rogulenko at google.com>'s request for review:
Bug 90264: Web Inspector: added low-level instrumentation support for
TimelineAgent
https://bugs.webkit.org/show_bug.cgi?id=90264

Attachment 150169: Patch
https://bugs.webkit.org/attachment.cgi?id=150169&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150169&action=review


> Source/WebCore/ChangeLog:8
> +	   * inspector/InspectorInstrumentation.cpp:

Please explain what happens and why here?

> Source/WebCore/inspector/InspectorInstrumentation.h:410
> +

Please roll back this change.

>> Source/WebCore/inspector/InspectorTimelineAgent.h:148
>> +	static void setInstance(InspectorTimelineAgent* inspectorTimelineAgent)
{ **ThreadSpecificInstance() = inspectorTimelineAgent; }
> 
> Why is this public?

I would rather move this method to the InspectorInstrumentation.