[webkit-reviews] review requested: [Bug 88807] Input elements with type=range do not have default touch handlers. : [Attachment 149538] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jun 29 07:05:51 PDT 2012
Kevin Ellis <kevers at chromium.org> has asked for review:
Bug 88807: Input elements with type=range do not have default touch handlers.
https://bugs.webkit.org/show_bug.cgi?id=88807
Attachment 149538: Patch
https://bugs.webkit.org/attachment.cgi?id=149538&action=review
------- Additional Comments from Kevin Ellis <kevers at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149538&action=review
>> Source/WebCore/dom/Touch.cpp:74
>> + float y = pageY * scaleFactor;
>
> I'm not sure whether this is the right idiom. Should we be using
FrameView::mapFromCSSToLayoutUnits instead?
Consistent with approach used in MouseReleatedEvent.cpp and EventHandler.cpp
for handling scaling.
More information about the webkit-reviews
mailing list