[webkit-reviews] review granted: [Bug 88326] [BlackBerry] [DRT] DRT should be able to run interactively and support multiple processes : [Attachment 150139] updated

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 29 04:54:18 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Xiaobo Wang
<xiaobo.wang at torchmobile.com.cn>'s request for review:
Bug 88326: [BlackBerry] [DRT] DRT should be able to run interactively and
support multiple processes
https://bugs.webkit.org/show_bug.cgi?id=88326

Attachment 150139: updated
https://bugs.webkit.org/attachment.cgi?id=150139&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=150139&action=review


Looks good.

> Tools/DumpRenderTree/blackberry/DumpRenderTree.cpp:324
> +	   fprintf(stderr, "Failed to open PPS file '%s', error=%d\n",
getPPSPath().c_str(), errno);

Is this our best log method?


More information about the webkit-reviews mailing list