[webkit-reviews] review granted: [Bug 90153] Web Inspector: Resource content is not loaded if Resource.requestContent method is called before network request is finished. : [Attachment 149932] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has granted Vsevolod Vlasov
<vsevik at chromium.org>'s request for review:
Bug 90153: Web Inspector: Resource content is not loaded if
Resource.requestContent method is called before network request is finished.
https://bugs.webkit.org/show_bug.cgi?id=90153

Attachment 149932: Patch
https://bugs.webkit.org/attachment.cgi?id=149932&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149932&action=review


>
LayoutTests/http/tests/inspector/resource-tree/resource-request-content-while-l
oading.html:27
> +	     contentWasRequested = true;

No need to set it second time

>
LayoutTests/http/tests/inspector/resource-tree/resource-request-content-while-l
oading.html:38
> +	     if (contentWasLoaded)

Page reload reply should always come before _addRequest unless you receive
_addRequest for the page that was not reloaded yet. Probably using a
synchronously loaded resources would allow to avoid this non-determinism.