[webkit-reviews] review denied: [Bug 89961] Web Inspector: Add DirectoryContentView for FileSystemView : [Attachment 149489] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 89961: Web Inspector: Add DirectoryContentView for FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=89961

Attachment 149489: Patch
https://bugs.webkit.org/attachment.cgi?id=149489&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149489&action=review


> Source/WebCore/inspector/front-end/DirectoryContentView.js:60
> +WebInspector.DirectoryContentView.columnIndices = {

We prefer indexes in inspector code.

> Source/WebCore/inspector/front-end/DirectoryContentView.js:61
> +    NAME: 0,

Name

> Source/WebCore/inspector/front-end/DirectoryContentView.js:63
> +    TYPE: 2,

Type

> Source/WebCore/inspector/front-end/DirectoryContentView.js:64
> +    SIZE: 3,

Size

> Source/WebCore/inspector/front-end/DirectoryContentView.js:65
> +    MTIME: 4

ModificationTime

> Source/WebCore/inspector/front-end/DirectoryContentView.js:100
> +	   if ("size" in metadata)

Isn't size always available?

> Source/WebCore/inspector/front-end/FileSystemView.js:98
> +	       } else {

else
    return