[webkit-reviews] review granted: [Bug 90250] Remove Leopard Accessibility support from WebCore (now that no port builds on Leopard) : [Attachment 150094] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 29 00:28:53 PDT 2012


Ryosuke Niwa <rniwa at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 90250: Remove Leopard Accessibility support from WebCore (now that no port
builds on Leopard)
https://bugs.webkit.org/show_bug.cgi?id=90250

Attachment 150094: Patch
https://bugs.webkit.org/attachment.cgi?id=150094&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150094&action=review


> Source/WebCore/accessibility/AccessibilityARIAGrid.cpp:46
>      m_isAccessibilityTable = true;

Should we initialize this on the initialization list now that if-def is gone?

> Source/WebCore/accessibility/AccessibilityTable.cpp:54
>      m_isAccessibilityTable = isTableExposableThroughAccessibility();

Ditto.


More information about the webkit-reviews mailing list