[webkit-reviews] review granted: [Bug 90204] Fix rebaselining for Qt and Apple ports : [Attachment 150033] Patch

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 90204: Fix rebaselining for Qt and Apple ports
https://bugs.webkit.org/show_bug.cgi?id=90204

Attachment 150033: Patch
https://bugs.webkit.org/attachment.cgi?id=150033&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150033&action=review


r+ w/ nits/questions.

> Tools/Scripts/webkitpy/layout_tests/port/builders.py:61
> +    "Apple Win XP Debug (Tests)": {"port_name": "win-xp", "specifiers":
set(["win", "debug"]), "rebaseline_override_dir": "win"},

shouldn't this be win-xp?

> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:94
>	   return port.baseline_path()

nit: can you change port.baseline_path() to port.baseline_version_dir() while
you're at it?

> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:49
> +	   self.assertEqual(command._baseline_directory("Apple Win XP Debug
(Tests)"), "/mock-checkout/LayoutTests/platform/win")

same comment re: -xp.