[webkit-reviews] review requested: [Bug 89039] Update ANGLE in WebKit : [Attachment 150022] Patch

[bugzilla-daemon at webkit.org]

Max Vujovic <mvujovic at adobe.com> has asked  for review:
Bug 89039: Update ANGLE in WebKit
https://bugs.webkit.org/show_bug.cgi?id=89039

Attachment 150022: Patch
https://bugs.webkit.org/attachment.cgi?id=150022&action=review

------- Additional Comments from Max Vujovic <mvujovic at adobe.com>
This patch is ready for review.

I'm updating ANGLE to r1170.

When trying to update to ANGLE r1147, I was getting build warnings on the QT
and GTK bots. I fixed the warnings and pushed the fixes to ANGLE in r1170.

However, between r1147 and r1170, ANGLE enabled its new preprocessor. This
caused a new build issue on QT, which I fixed in this patch by renaming two
files. 

To avoid chasing a moving target, I plan on fixing this issue in ANGLE after
this patch. The issue and fix is described the ChangeLog, pasted below:

"""
Update ANGLE to r1170, with the following modifications:

Rename ANGLE/src/compiler/preprocessor/new/Diagnostic.cpp to
DiagnosticBase.cpp.
Rename ANGLE/src/compiler/preprocessor/new/DirectiveHandler.cpp to
DirectiveHandlerBase.cpp.

With the introduction of ANGLE's new preprocessor, there were two files named
Diagnostic.cpp in ANGLE under different folders. This caused problems on the QT
build when their object files, both named Diagnostic.o, tried to go in the same
folder. Renaming one of them to DirectiveHandlerBase.cpp avoids this conflict.
The same situation occurred with DirectiveHandler.cpp. I will try to get their
names changed in ANGLE for future updates.
"""