[webkit-reviews] review granted: [Bug 89580] Suppress horizontal conversion of PlatformWheelEvents when hasPreciseScrollingDeltas is true : [Attachment 150023] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Robert Kroeger
<rjkroege at chromium.org>'s request for review:
Bug 89580: Suppress horizontal conversion of PlatformWheelEvents when
hasPreciseScrollingDeltas is true
https://bugs.webkit.org/show_bug.cgi?id=89580

Attachment 150023: Patch
https://bugs.webkit.org/attachment.cgi?id=150023&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150023&action=review


This looks good, but you've got some crazy indenting with tabs going on.

> LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-sideways.html:26
> +    /* border-radius: 10px; */

Why are these commented out?

> LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-sideways.html:107
> +		secondWheelScroll();
> +		return;

Looks like some tabs snuck in.

> LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-sideways.html:111
> +		debug("without precise deltas, scrollLeft: " +
movingdiv.scrollLeft + " scrollTop: " + movingdiv.scrollTop);

Here too