[webkit-reviews] review granted: [Bug 17767] frameborder="no" on frameset is ignored if border attribute set : [Attachment 150013] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 28 14:35:02 PDT 2012


Tony Chang <tony at chromium.org> has granted Elliott Sprehn <esprehn at gmail.com>'s
request for review:
Bug 17767: frameborder="no" on frameset is ignored if border attribute set
https://bugs.webkit.org/show_bug.cgi?id=17767

Attachment 150013: Patch
https://bugs.webkit.org/attachment.cgi?id=150013&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=150013&action=review


> Source/WebCore/html/HTMLFrameSetElement.cpp:101
> +	       } else if (equalIgnoringCase(value, "yes") ||
equalIgnoringCase(value, "1")) {
> +		   // Default is true.

I think this comment is confusing (it's not obvious we're talking about
m_border). I would just remove it.


More information about the webkit-reviews mailing list