[webkit-reviews] review granted: [Bug 72443] Implement url() filter function : [Attachment 149050] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 28 13:38:10 PDT 2012


Dean Jackson <dino at apple.com> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 72443: Implement url() filter function
https://bugs.webkit.org/show_bug.cgi?id=72443

Attachment 149050: Patch
https://bugs.webkit.org/attachment.cgi?id=149050&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149050&action=review


Thanks Stephen. Small comments.

> Source/WebCore/GNUmakefile.list.am:1760
> +	Source/WebCore/css/WebKitCSSSVGDocumentValue.cpp \
> +	Source/WebCore/css/WebKitCSSSVGDocumentValue.h \
>	Source/WebCore/css/WebKitCSSShaderValue.cpp \

Should PlatformLayer.h be here too? (Missed this the first time)

> Source/WebCore/WebCore.vcproj/WebCore.vcproj:37570
> +			<File
> +				RelativePath="..\css\WebKitCSSShaderValue.cpp"

And in this file too?

> Source/WebCore/platform/graphics/filters/FilterOperation.h:190
> +    void* m_data;

This is the bit I'm most worried about, but as you mentioned, there are not any
easy solutions. Maybe we could file a followup to clean this up?

> Source/WebCore/rendering/FilterEffectRenderer.cpp:141
> +    // FIXME: Figure out what to do with SourceAlpha. Right now, we're
> +    // using the alpha of the original input layer, which is obviously
> +    // wrong. We should probably be extracting the alpha from the 
> +    // previousEffect, but this requires some more processing.  
> +    // This may need a spec clarification.

Could you file a spec bug on this and link from here?


More information about the webkit-reviews mailing list