[webkit-reviews] review granted: [Bug 90199] Improve compositing logging output : [Attachment 149993] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 90199: Improve compositing logging output
https://bugs.webkit.org/show_bug.cgi?id=90199

Attachment 149993: Patch
https://bugs.webkit.org/attachment.cgi?id=149993&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149993&action=review


> Source/WebCore/ChangeLog:11
> +	   2. Show element classnames

s/classnames/class names/?

> Source/WebCore/platform/graphics/GraphicsLayer.cpp:518
> +    return static_cast<double>(4 * size().width()) * size().height();

Can we strictly assume {RGBA (in whatever order)}8888 for everyone?

> Source/WebCore/rendering/RenderLayerBacking.cpp:1544
> +	       name += " id=\'" + static_cast<Element*>(node)->getIdAttribute()
+ "\'";

This is going to be awesome.