[webkit-reviews] review granted: [Bug 90111] Cleanup HTMLFormCollection : [Attachment 149824] Cleanup
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jun 28 12:00:03 PDT 2012
Andreas Kling <kling at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 90111: Cleanup HTMLFormCollection
https://bugs.webkit.org/show_bug.cgi?id=90111
Attachment 149824: Cleanup
https://bugs.webkit.org/attachment.cgi?id=149824&action=review
------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149824&action=review
> Source/WebCore/ChangeLog:8
> + Got rid of getNamedItem and enamed getNamedFormItem to
firstNamedItem and got rid of duplicateNumber argument since
Typo, enamed.
> Source/WebCore/html/HTMLFormCollection.cpp:126
> + if (elementsArray[i]->isEnumeratable() &&
element->fastGetAttribute(attrName) == name)
Maybe someone should rename isEnumeratable() this to isEnumerable() someday.
More information about the webkit-reviews
mailing list