[webkit-reviews] review requested: [Bug 90092] [chromium] ContentLayerPainter should generate opaque rects in content space : [Attachment 149980] Patch

[bugzilla-daemon at webkit.org]

vollick at chromium.org has asked	for review:
Bug 90092: [chromium] ContentLayerPainter should generate opaque rects in
content space
https://bugs.webkit.org/show_bug.cgi?id=90092

Attachment 149980: Patch
https://bugs.webkit.org/attachment.cgi?id=149980&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #9)
> (From update of attachment 149966 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=149966&action=review
>
> > Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:75
> > +	 PlatformContextSkia platformContext(canvas);
> > +	 GraphicsContext context(&platformContext);
>
> Sorry this is a layering no-no.  CanvasLayerTextureUpdater needs to not be
aware of GraphicsContext / PlatformContext, only skia concepts since it's part
of the compositor implementation.
Fixed.
>
> > Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:83
> > +	 canvasToContentTransform *= context.getCTM().inverse();
>
> Are you just trying to do matrix math here, or actually use GraphicsContext
for something else?

Yep, I was just trying to do matrix math here, but as you pointed out, we know
everything about the transforms here, so not only do we not need to ask the
canvas for its transform, the matrix math isn't necessary,
either. We will always end up with a straight translation.