[webkit-reviews] review granted: [Bug 90186] Make rebaseline-test and rebseline-expectations work for non-Chromium ports : [Attachment 149968] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 90186: Make rebaseline-test and rebseline-expectations work for
non-Chromium ports
https://bugs.webkit.org/show_bug.cgi?id=90186

Attachment 149968: Patch
https://bugs.webkit.org/attachment.cgi?id=149968&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149968&action=review


> Tools/Scripts/webkitpy/tool/commands/rebaseline.py:84
> +	   if port.name().startswith('chromium-'):

Should we have a way to ask the port whether it's a Chromium port rather than
using string operations?

> Tools/Scripts/webkitpy/tool/commands/rebaseline_unittest.py:257
> +MOCK run_command: ['qmake', '-v'], cwd=None
> +MOCK run_command: ['qmake', '-v'], cwd=None
> +MOCK run_command: ['qmake', '-v'], cwd=None
> +MOCK run_command: ['qmake', '-v'], cwd=None

What's up with the qmake calls?  Will this error out on systems that don't have
qmake?