[webkit-reviews] review requested: [Bug 90094] [chromium] use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests : [Attachment 149974] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 28 11:12:12 PDT 2012


Shawn Singh <shawnsingh at chromium.org> has asked  for review:
Bug 90094: [chromium] use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90094

Attachment 149974: Patch
https://bugs.webkit.org/attachment.cgi?id=149974&action=review

------- Additional Comments from Shawn Singh <shawnsingh at chromium.org>
Sorry for the churn; I had to revert anyway because of a windows-only build
error.	This patch addresses reviewer's previous comments, and fixes windows
build errors on PopupMenuTest.cpp.  Otherwise it is the same.


More information about the webkit-reviews mailing list