[webkit-reviews] review denied: [Bug 86022] Refactor layer-related logic out of RenderBoxModelObject : [Attachment 149971] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 28 10:56:38 PDT 2012


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 86022: Refactor layer-related logic out of RenderBoxModelObject
https://bugs.webkit.org/show_bug.cgi?id=86022

Attachment 149971: Patch
https://bugs.webkit.org/attachment.cgi?id=149971&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=149971&action=review


> Source/WebCore/rendering/RenderLayerObject.h:29
> +class RenderLayerObject : public RenderObject {

I don't really like the class name. I'd prefer to pick a name that reflects
what's common about RenderBoxModelObject and RenderSVG stuff in terms of
behavior, not in terms of implementation. I'd also like to reduce the ties
between RenderObjects and RenderLayers, not strengthen them, conceptually.


More information about the webkit-reviews mailing list