[webkit-reviews] review denied: [Bug 90092] [chromium] ContentLayerPainter should generate opaque rects in content space : [Attachment 149966] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied vollick at chromium.org's request
for review:
Bug 90092: [chromium] ContentLayerPainter should generate opaque rects in
content space
https://bugs.webkit.org/show_bug.cgi?id=90092

Attachment 149966: Patch
https://bugs.webkit.org/attachment.cgi?id=149966&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149966&action=review


> Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:75
> +    PlatformContextSkia platformContext(canvas);
> +    GraphicsContext context(&platformContext);

Sorry this is a layering no-no.  CanvasLayerTextureUpdater needs to not be
aware of GraphicsContext / PlatformContext, only skia concepts since it's part
of the compositor implementation.

> Source/WebCore/platform/graphics/chromium/CanvasLayerTextureUpdater.cpp:83
> +    canvasToContentTransform *= context.getCTM().inverse();

Are you just trying to do matrix math here, or actually use GraphicsContext for
something else?