[webkit-reviews] review granted: [Bug 89732] [Refactoring] NodeRenderingContext ctor could be built on top of the ComposedShadowTreeWalker : [Attachment 149899] Patch

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hajime Morrita
<morrita at google.com>'s request for review:
Bug 89732: [Refactoring] NodeRenderingContext ctor could be built on top of the
ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=89732

Attachment 149899: Patch
https://bugs.webkit.org/attachment.cgi?id=149899&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149899&action=review


> Source/WebCore/dom/NodeRenderingContext.h:73
> +    ComposedShadowTreeWalker::ParentTranversalDetails m_parent;

In this neck of the woods, m_parent usually means a ContainerNode*. Can we name
this more precisely? m_parentTraversalDetails is a bit too verbose, but maybe
m_parentDetails?