[webkit-reviews] review requested: [Bug 90178] [Qt] Remove unnecessary AffineTransform construction while calling Pattern::createPlatformPattern : [Attachment 149949] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 28 07:17:00 PDT 2012


Bruno Abinader <bruno.abinader at basyskom.com> has asked	for review:
Bug 90178: [Qt] Remove unnecessary AffineTransform construction while calling
Pattern::createPlatformPattern
https://bugs.webkit.org/show_bug.cgi?id=90178

Attachment 149949: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=149949&action=review

------- Additional Comments from Bruno Abinader <bruno.abinader at basyskom.com>
This patch fixes the issue by removing all unused calls for AffineTransform. I
also thought about adding a clear AffineTransform object as default parameter
for the Pattern::createPlatformPattern function, but it would still be creating
an unused object on Qt afterall. What do you guys think?


More information about the webkit-reviews mailing list