[webkit-reviews] review canceled: [Bug 84540] JS binding code generator doesn't handle "attribute unsigned long[]" well : [Attachment 138573] Patch_With_Traits

[bugzilla-daemon at webkit.org]

Vineet Chaudhary (vineetc) <rgf748 at motorola.com> has canceled Vineet Chaudhary
(vineetc) <rgf748 at motorola.com>'s request for review:
Bug 84540: JS binding code generator doesn't handle "attribute unsigned long[]"
well
https://bugs.webkit.org/show_bug.cgi?id=84540

Attachment 138573: Patch_With_Traits
https://bugs.webkit.org/attachment.cgi?id=138573&action=review

------- Additional Comments from Vineet Chaudhary (vineetc)
<rgf748 at motorola.com>
Updated patch to simplify the JSDOMBinding.h and V8Binding.h replacing
specialised functions with traits.
So in future if someone wants to add jsArray() for new datatype need not to
write jsArray() again.
eg. For "unsigned int" it needs to add below code only.
   template<>
    struct traits<unsigned int> {
	static inline JSC::JSValue arrayJSValue(JSC::ExecState* ,
JSDOMGlobalObject*, const unsigned int& value)
	{
	    return JSC::jsNumber(value);
	}
    };
Same for V8Binding too.

Also now I don't see the dependency of this bug for Bug84929. Can we remove it
from block list?