[webkit-reviews] review denied: [Bug 73301] Web Inspector: Add FileSystemView : [Attachment 149905] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 28 04:47:14 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has denied Taiju Tsuiki
<tzik at chromium.org>'s request for review:
Bug 73301: Web Inspector: Add FileSystemView
https://bugs.webkit.org/show_bug.cgi?id=73301

Attachment 149905: Patch
https://bugs.webkit.org/attachment.cgi?id=149905&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149905&action=review


Please fix how the root element is expanded. Other than that looks good.

> Source/WebCore/inspector/front-end/FileSystemView.js:48
> +    rootItem.expand();

I don't think this will work because expand() should not be called until
TreeElement is attached. 
You should set expanded to true instead: rootItem.expanded = true;
expand() will be called from TreeElement._attach automatically then.

> Source/WebCore/inspector/front-end/FileSystemView.js:76
> +WebInspector.FileSystemView.Entry = function(fileSystemView, entry)

nit: I would rename it to EntryTreeElement to avoid confusion with
FileSystemModel.Entry.


More information about the webkit-reviews mailing list