[webkit-reviews] review denied: [Bug 89735] Web Inspector: Provide context menu 'Delete all watch expressions.' : [Attachment 149909] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 28 03:15:18 PDT 2012


Yury Semikhatsky <yurys at chromium.org> has denied Rahul Tiwari
<rahultiwari.cse.iitr at gmail.com>'s request for review:
Bug 89735: Web Inspector: Provide context menu 'Delete all watch expressions.'
https://bugs.webkit.org/show_bug.cgi?id=89735

Attachment 149909: Patch
https://bugs.webkit.org/attachment.cgi?id=149909&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149909&action=review


> Source/WebCore/inspector/front-end/WatchExpressionsSidebarPane.js:263
> +	   this.watchExpressions.splice(0, expressionCount);

Please this.watchExpressions = []; as in the previous patch and file a bug that
WebInspector.Setting.get() should return a copy of the setting value.


More information about the webkit-reviews mailing list