[webkit-reviews] review canceled: [Bug 48610] [Chromium] Implement hyphenation for Chromium : [Attachment 149882] Applied comments and moved the stub functions to Platform.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Jun 27 23:46:33 PDT 2012
Hironori Bono <hbono at chromium.org> has canceled Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 48610: [Chromium] Implement hyphenation for Chromium
https://bugs.webkit.org/show_bug.cgi?id=48610
Attachment 149882: Applied comments and moved the stub functions to Platform.
https://bugs.webkit.org/attachment.cgi?id=149882&action=review
------- Additional Comments from Hironori Bono <hbono at chromium.org>
Greetings,
Sorry for this style error. I forgot running webkit-check-style.
I have uploaded another change that fixes this style error.
Regards,
Hironori Bono
(In reply to comment #14)
> Attachment 149882 [details] did not pass style-queue:
>
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files',
u'Source/Platform/ChangeLog', u'Source/Platf..." exit_code: 1
> Source/WebCore/platform/text/chromium/Hyphenation.cpp:27: You should add a
blank line after implementation file's own header. [build/include_order] [4]
> Total errors found: 1 in 5 files
>
>
> If any of these errors are false positives, please file a bug against
check-webkit-style.
More information about the webkit-reviews
mailing list