[webkit-reviews] review requested: [Bug 89965] [Platform] Implement functions for localized time format information : [Attachment 149872] Patch 2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 27 22:40:59 PDT 2012


yosin at chromium.org has asked  for review:
Bug 89965: [Platform] Implement functions for localized time format information
https://bugs.webkit.org/show_bug.cgi?id=89965

Attachment 149872: Patch 2
https://bugs.webkit.org/attachment.cgi?id=149872&action=review

------- Additional Comments from yosin at chromium.org
Could you review this patch?
Thanks in advance.

= Changes since last review =
* Replace INPUT_TIME_FIELDS => INPUT_TYPE_TIME_MULTIPLE_FIELDS
* Replace periodLabels => timeAMPMLabels
** Thanks for suggestion. This is more explicit.
** For consistency of month names and weekday names, returning vector seems to
be better.
* Having TimeFormat and ShortTimeFormat for displaying only two fields hour and
minute when step >= 60. There is no way to remove second field from "h:m:s"
pattern string. We don't know whether ":" after "m" belongs minute or second
field.


More information about the webkit-reviews mailing list