[webkit-reviews] review granted: [Bug 89468] [Qt] KURL assert at fast/loader/opaque-base-url.html : [Attachment 149725] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 89468: [Qt] KURL assert at fast/loader/opaque-base-url.html
https://bugs.webkit.org/show_bug.cgi?id=89468

Attachment 149725: Patch
https://bugs.webkit.org/attachment.cgi?id=149725&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Yeah, this seems to be in line with what the other ports are using.

However at the same time this is an example of unnecessary code duplication
between ports that could easily be cleaned up. Mac and Win implementations
using CFNetwork appear to just encode and decode the entire underlying
dictionary. Gtk, Efl and Qt ports are either just storing the URL or (in the
case of the Gtk port) also more meta-data.

I think it would be really nice to _share_ a non-CFNetwork based implementation
that saves/restores more properties of ResourceRequestBase and leaves room for
a platform specific properties in the ResourceRequest sub-class.

Then issues like these are less likely to happen because there's more code
coverage through the other ports.