[webkit-reviews] review denied: [Bug 89965] [Platform] Implement functions for localized time format information : [Attachment 149716] Patch 1

[bugzilla-daemon at webkit.org]

Kent Tamura <tkent at chromium.org> has denied yosin at chromium.org's request for
review:
Bug 89965: [Platform] Implement functions for localized time format information
https://bugs.webkit.org/show_bug.cgi?id=89965

Attachment 149716: Patch 1
https://bugs.webkit.org/attachment.cgi?id=149716&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149716&action=review


> Source/WebCore/ChangeLog:10
> +	     1. localizedTimeFormatText()
> +	     2. localizedShortTimeFormatText()

Why do you need both of non-short and short formats?

> Source/WebCore/ChangeLog:11
> +	     2. periodLabels()

The name periodLabels() is too short and not concrete.
How about timeAMPMabels(), or separate it into timeAMLabel() and timePMLabel()?


> Source/WebKit/chromium/ChangeLog:32
> +2012-06-27  Yoshifumi Inoue	<yosin at chromium.org>
> +
> +	   Need a short description and bug URL (OOPS!)
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * WebKit.gypi:
> +

Please remove it.