[webkit-reviews] review granted: [Bug 90094] [chromium] use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests : [Attachment 149809] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Shawn Singh
<shawnsingh at chromium.org>'s request for review:
Bug 90094: [chromium] use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90094

Attachment 149809: Patch
https://bugs.webkit.org/attachment.cgi?id=149809&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149809&action=review


Looks good to me.

Adam and I talked about having two test targets a bit yesterday - it sounds
like a good idea, but it might get really confusing for someone writing a new
test to figure out which sort of thing they were writing and where it should
go.  Would they live in different directories?

> Source/WebKit/chromium/public/WebDOMMessageEvent.h:49
> +    WebDOMMessageEvent() { };

no ;