[webkit-reviews] review requested: [Bug 90094] [chromium] use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests : [Attachment 149809] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 27 16:03:15 PDT 2012


Shawn Singh <shawnsingh at chromium.org> has asked  for review:
Bug 90094: [chromium] use WEBKIT_IMPLEMENTATION == 1 for webkit_unit_tests
https://bugs.webkit.org/show_bug.cgi?id=90094

Attachment 149809: Patch
https://bugs.webkit.org/attachment.cgi?id=149809&action=review

------- Additional Comments from Shawn Singh <shawnsingh at chromium.org>
The URL logic had a lot of redundancy that was just slightly different in each
place --> a haven for frustrating bugs. So I went ahead and refactored it and
cleaned it up, along with this patch.


More information about the webkit-reviews mailing list