[webkit-reviews] review denied: [Bug 62214] [Chromium] DumpRenderTree should reset ganesh between tests : [Attachment 149108] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Keyar Hood
<keyar at chromium.org>'s request for review:
Bug 62214: [Chromium] DumpRenderTree should reset ganesh between tests
https://bugs.webkit.org/show_bug.cgi?id=62214

Attachment 149108: Patch
https://bugs.webkit.org/attachment.cgi?id=149108&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
I feel like this is a move in the wrong direction. We reset test state between
tests and any settings that we may have clobbered, but it feels wrong to reset
arbitrary WebCore state.  In practice we need the shared context to work across
many pages - I don't see any reason why DumpRenderTree should be different.  We
don't reset the memory cache between tests.

The motivation for this was a bug in skia where it wasn't correctly tracking
its own internal state.  While that turned out to be a pain to track down
debug, in the end it was a bug in skia and something that should be tested in
skia.  It's not a concern of WebKit - there isn't any state that is being
managed by WebKit beyond the context itself.