[webkit-reviews] review granted: [Bug 90001] IndexedDB: Hook up render-side key ASSERTing for get() : [Attachment 149786] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 90001: IndexedDB: Hook up render-side key ASSERTing for get()
https://bugs.webkit.org/show_bug.cgi?id=90001

Attachment 149786: Patch
https://bugs.webkit.org/attachment.cgi?id=149786&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
Might be nice to have a clean ews run before landing.

View in context: https://bugs.webkit.org/attachment.cgi?id=149786&action=review


> Source/WebCore/ChangeLog:28
> +	   (WebCore):
> +
> +2012-06-26  Joshua Bell  <jsbell at chromium.org>
> +

Looks like a merge conflict?

> Source/WebCore/inspector/InspectorIndexedDBAgent.cpp:115
>      virtual void onSuccess(PassRefPtr<IDBTransactionBackendInterface>) { }
>      virtual void onSuccess(PassRefPtr<SerializedScriptValue>) { }
> +    virtual void onSuccess(PassRefPtr<SerializedScriptValue>,
PassRefPtr<IDBKey>, const IDBKeyPath&) { }

Nit: Should these all have OVERRIDE?