[webkit-reviews] review granted: [Bug 90016] IndexedDB: const-ify IDBKey : [Attachment 149782] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 90016: IndexedDB: const-ify IDBKey
https://bugs.webkit.org/show_bug.cgi?id=90016

Attachment 149782: Patch
https://bugs.webkit.org/attachment.cgi?id=149782&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=149782&action=review


> Source/WebCore/ChangeLog:3
> +	   IndexedDB: const-ify IDBKey

Nit: I would probably use immutable in the title, since it's more descriptive
than const-ify.

> Source/WebCore/Modules/indexeddb/IDBKey.h:153
> +    IDBKey(const String& value) : m_type(StringType), m_string(value),
m_number(0), m_sizeEstimate(kOverheadSize + value.length() * sizeof(UChar)) { }


Nit: explicit