[webkit-reviews] review granted: [Bug 88640] [V8] Types should be wrapped at their base type and downcast when unwrapped : [Attachment 149697] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 27 09:37:11 PDT 2012


Nate Chapin <japhet at chromium.org> has granted Dominic Cooney
<dominicc at chromium.org>'s request for review:
Bug 88640: [V8] Types should be wrapped at their base type and downcast when
unwrapped
https://bugs.webkit.org/show_bug.cgi?id=88640

Attachment 149697: Patch
https://bugs.webkit.org/attachment.cgi?id=149697&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
I have vague concerns that there people will forget to static_cast before
wrapping. However, I'm not immediately seeing a defense against that other than
careful review, and it seems an improvement over the current quirks.

LGTM


More information about the webkit-reviews mailing list