[webkit-reviews] review canceled: [Bug 89461] Web Inspector: Design WebSockets panel : [Attachment 149370] Put back Date column, drop Mask column

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 27 04:38:41 PDT 2012


Nikita Vasilyev <me at elv1s.ru> has canceled Nikita Vasilyev <me at elv1s.ru>'s
request for review:
Bug 89461: Web Inspector: Design WebSockets panel
https://bugs.webkit.org/show_bug.cgi?id=89461

Attachment 149370: Put back Date column, drop Mask column
https://bugs.webkit.org/attachment.cgi?id=149370&action=review

------- Additional Comments from Nikita Vasilyev <me at elv1s.ru>
(In reply to comment #13)
> If you're going to show the opcode, would it make sense to label it as "Frame
type" and put the actual textual description? I.e. "Text", "Continuation", etc.


I will try it out in a separate bug.

(In reply to comment #14)
> I am strongly for the length column. In my experience, many packets have 4-6
digit lengths and I can figure out which one i need by seeking through the
length column. The content itself is not that valuable to me: we always use our
own protocols / methods to serialize the data we send. So all prefixes (these
80+ characters) are going to be pretty much the same (some generic headers in
messages). So I'm voting for the
> - length column,
> - truncated one line data previews with ellipsis by default
> - ability to get full data preview upon action

Ditto.


More information about the webkit-reviews mailing list